Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add junit5-migration-maven-kotlin sample #105 PR #107

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

daggerok
Copy link
Contributor

Overview

This PR contains junit5-migration-maven-kotlin project demonstrates how to execute tests written in Java and Kotlin based on JUnit 5 using Maven. In addition, it showcases that existing JUnit 4 based tests can be executed in the same test suite as JUnit Jupiter based tests or any other tests supported on the JUnit Platform.


I hereby agree to the terms of the JUnit Contributor License Agreement.

@daggerok daggerok force-pushed the junit5-migration-maven-kotlin branch 2 times, most recently from 20e6f18 to 8233495 Compare May 28, 2019 19:47
@daggerok daggerok changed the title Add junit5-migration-maven-kotlin sample #105 Add junit5-migration-maven-kotlin sample #105 PR May 28, 2019
@daggerok daggerok force-pushed the junit5-migration-maven-kotlin branch from 8233495 to 6c41368 Compare May 28, 2019 19:53
@daggerok daggerok force-pushed the junit5-migration-maven-kotlin branch from 6c41368 to 98c2e9b Compare May 28, 2019 22:47
@marcphilipp marcphilipp changed the base branch from master to main June 19, 2020 18:29
Copy link

@donphelix donphelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just simple grammatical errors, please update as suggested above.

### Maven & Kotlin Migration ![badge-jdk-8] ![badge-tool-maven] ![badge-junit-jupiter] ![badge-junit-vintage]

The [junit5-migration-maven-kotlin] sample demonstrates how to execute tests written in Java and Kotlin
based on JUnit 5 using Maven. In addition, it showcases that existing JUnit 4 based tests can be executed

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
based on JUnit 5 using Maven. In addition, it showcases that existing JUnit 4 based tests can be executed
using JUnit 5 with Maven. Additionally, it demonstrates that existing JUnit 4 tests can also be executed

based on JUnit 5 using Maven. In addition, it showcases that existing JUnit 4 based tests can be executed
in the same test suite as JUnit Jupiter based tests or any other tests supported on the JUnit Platform.

Please note that this project is uses the [Maven Wrapper](https://github.com/takari/maven-wrapper)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Please note that this project is uses the [Maven Wrapper](https://github.com/takari/maven-wrapper)
Please note that this project uses the [Maven Wrapper](https://github.com/takari/maven-wrapper)

in the same test suite as JUnit Jupiter based tests or any other tests supported on the JUnit Platform.

Please note that this project is uses the [Maven Wrapper](https://github.com/takari/maven-wrapper)
3.6.1 version. This helps you ensure that already tested versions are not going to be failed if

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3.6.1 version. This helps you ensure that already tested versions are not going to be failed if
Version 3.6.1. This ensures that previously tested versions remain functional and are not disrupted if


Please note that this project is uses the [Maven Wrapper](https://github.com/takari/maven-wrapper)
3.6.1 version. This helps you ensure that already tested versions are not going to be failed if
locally installed different maven version.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
locally installed different maven version.
a different Maven version installed locally


The junit5-migration-maven-kotlin project demonstrates how to execute tests written in Java and Kotlin
based on JUnit 5 using Maven. In addition, it showcases that existing JUnit 4 based tests can be executed
in the same test suite as JUnit Jupiter based tests or any other tests supported on the JUnit Platform.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
in the same test suite as JUnit Jupiter based tests or any other tests supported on the JUnit Platform.
within the same test suite as JUnit Jupiter tests or any other tests supported by the JUnit Platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants